chore: fixed the 'aarch64-unknown-linux-gnu' cross compilation issue on macOS-arm64.#171
Open
vincent-dfinity wants to merge 1 commit intobrson:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables cross-compiling to
aarch64-unknown-linux-gnutarget onmacOS-arm64.brew install aarch64-unknown-linux-gnuandrustup target add aarch64-unknown-linux-gnufirst.-D__STDC_FORMAT_MACROScompilation flag is used to fix the cinttypes issues.Some macros like PRIx64, PRIx32, PRIxPTR used by binaryen are not defined by default even including
cinttypes.I only focus on compiling
aarch64-unknown-linux-gnuonmacOS-arm64, not sure about other combinations. It may not be the best solution.