Reduce macOS update task polling frequency#1777
Open
learningpro wants to merge 2 commits intochen08209:mainfrom
Open
Reduce macOS update task polling frequency#1777learningpro wants to merge 2 commits intochen08209:mainfrom
learningpro wants to merge 2 commits intochen08209:mainfrom
Conversation
Reduce macOS update task polling frequency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The background update loop was scheduling tasks every second which can increase CPU usage and cause macOS devices to run hot, so the polling frequency should be relaxed on macOS and reduced further when the app window is hidden.
Description
Change startUpdateTasks to use a new helper _resolveUpdateInterval() and schedule the next run with the returned Duration; _resolveUpdateInterval() returns Duration(seconds: 1) by default, Duration(seconds: 3) on macOS when the window is visible, and Duration(seconds: 10) on macOS when the window is hidden.
Testing
No automated tests were run for this change.