(maintainertoolkit) Adds new maintainertoolkit package#2778
(maintainertoolkit) Adds new maintainertoolkit package#2778steviecoaster wants to merge 2 commits intochocolatey-community:masterfrom
Conversation
AdmiringWorm
left a comment
There was a problem hiding this comment.
I few things to update, and from the look of the description, you haven't ensured that the description is below 4 000 characters (I haven't checked either), that the package is up to date with our Contribution Guidelines, nor that the package works as expected in the Chocolatey Test Environment.
Those three are required to have been done before merging in a PR.
| Description = 'Framework for keeping packages automatically up to date. Most community packages use this.' | ||
| } | ||
| [PSCustomObject]@{ | ||
| Name = 'JSONPath/Fiddler / Browser DevTools' |
There was a problem hiding this comment.
Is there meant to be a space between the JSONPath and Fiddler and the slash?
Similar to what you have between Fiddler and Browser
There was a problem hiding this comment.
I think simplifying to just 'Fiddler' makes sense here!
| <id>maintainertoolkit</id> | ||
| <version>1.0.0</version> | ||
| <packageSourceUrl>https://github.com/chocolatey-community/chocolatey-packages/blob/master/manual/maintainertoolkit/</packageSourceUrl> | ||
| <owners>chocolatey-community</owners> |
There was a problem hiding this comment.
It is preferable to have at least one more user specified in the nuspec file, other than the chocolatey-community user.
| <owners>chocolatey-community</owners> | |
| <owners>chocolatey-community,steviecoaster</owners> |
| <packageSourceUrl>https://github.com/chocolatey-community/chocolatey-packages/blob/master/manual/maintainertoolkit/</packageSourceUrl> | ||
| <owners>chocolatey-community</owners> | ||
| <title>Chocolatey Package Maintenance Toolkit</title> | ||
| <authors>Chocolatey</authors> |
There was a problem hiding this comment.
Should this maybe be:
| <authors>Chocolatey</authors> | |
| <authors>Chocolatey Software</authors> |
Normally, i would suggest Chocolatey Software, Inc, but since it isn't handled correctly on CCR, I think teh above is a better value.
| <licenseUrl>https://github.com/chocolatey-community/chocolatey-packages/blob/master/manual/maintainertoolkit/LICENSE.md</licenseUrl> | ||
| <mailingListUrl>https://ch0.co/community</mailingListUrl> | ||
| <bugTrackerUrl>https://github.com/chocolatey-community/chocolatey-packages/issues</bugTrackerUrl> | ||
| <tags>maintainertoolkit packaging developer</tags> |
There was a problem hiding this comment.
The tags doesn't match the obligitary tags in this repository, can you please have a look at the contribution guidelines, and make the appropriate changes to this?
There was a problem hiding this comment.
I don't mind including this file, but just want to note that it won't be used anywhere in our systems. A ReadMe is only imported to the nuspec file when running the package creation/updating through AU.
This commit addresses chocolatey-community#2777 and adds a new manual package called maintainertoolkit, a metapackage to provide a set of development tools to aid in the creation and ongoing maintenance of Chocolatey packages. Primarily for the Chocolatey Community Repository, this package can also provide value to organizations looking to author and maintain packages internally.
- Fixes tags in nuspec - Fixes Author in nuspec - Fixes git dependency version number - Adds second maintainer name - Clarifies output in install script
|
@AdmiringWorm, this works in the chocolatey-test-environment, but only if the VSCode package installs first. The vscode-powershell package doesn't include a dependency path that ensures vscode is installed, so it can fail to install the package. Re-running the install is successful, since at that point the VS Code package was installed; the VS Code-Powershell package is fine. Unsure how to handle this in this package, since we can't guarantee the dependency order. I could just remove the vscode-powershell package, but I don't really want to. |
You could just issue the code command to install the extension in a chocolateyinstall.ps1... The vscode-powershell package doesn't take a dependency because it could be user or system install and stable or insiders. |
Description
maintainertoolkitis a metapackage to provide a set of development tools to aid in the creation and ongoing maintenance of Chocolatey packages. Primarily for the Chocolatey Community Repository, this package can also provide value to organizations looking to author and maintain packages internally.Motivation and Context
Fixes #2777
How Has this Been Tested?
Developed and tested in a Windows Sandbox VM
Screenshot (if appropriate, usually isn't needed):
Types of changes
Checklist: