Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 37 37
Lines 18148 18151 +3
=======================================
+ Hits 16661 16664 +3
Misses 1487 1487 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
Hmm, it must be late 😆. I'll fix it to actually work, and merge it with the not-public |
1b0831a to
1091e16
Compare
djc
reviewed
Apr 6, 2024
Member
djc
left a comment
There was a problem hiding this comment.
Can you just squash these commits and make sure that days_since() lives underneath the existing methods?
(You can keep the original author around with an Co-authored-by: tag in the commit message.)
Collaborator
Author
|
'Co-authored-by:` is new for me, I'll have to learn about that. |
Co-authored-by: Paul Dicker <paul@pitdicker.nl>
Collaborator
Author
|
Thank you! It doesn't render special in Git Gui, but I guess this is it... |
djc
approved these changes
Apr 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resurrects the work in #216 by @clarfonthey.
WeekDay::days_sincedoesn't offer any new functionality, but I quite like its API.Fixes #201, #1560.