Skip to content

Normalize dist layout and disable npm rebuild in release workflow#34

Merged
cita-777 merged 2 commits intomainfrom
codex/run-release.yml-to-simulate-github-actions-8hwayv
Mar 6, 2026
Merged

Normalize dist layout and disable npm rebuild in release workflow#34
cita-777 merged 2 commits intomainfrom
codex/run-release.yml-to-simulate-github-actions-8hwayv

Conversation

@cita-777
Copy link
Owner

@cita-777 cita-777 commented Mar 6, 2026

Motivation

  • Ensure the downloaded build artifact is placed and normalized into a consistent dist/desktop layout across Windows, Linux and macOS runners.
  • Avoid downloading and extracting AppImage tooling when not required by simplifying layout handling.
  • Make desktop packaging more deterministic and faster by disabling automatic npm rebuild during package:desktop runs.

Description

  • Changed the artifact download path from . to dist so the downloaded artifact is placed under dist/.
  • Added a Windows-specific normalization step (PowerShell) that moves or copies top-level desktop, web, and server folders into dist/ and validates that dist/desktop/main.js exists.
  • Replaced the previous Linux/macOS normalization that fetched AppImage tools with a simpler shell step that flattens dist/dist/ or moves top-level folders into dist/ and verifies dist/desktop/main.js.
  • Updated desktop package steps on Windows, Linux and macOS to run npm run package:desktop -- --config.npmRebuild=false and removed the AppImage tools env variable and prefetch logic.

Testing

  • No automated tests were executed as part of this change.

Codex Task

Summary by CodeRabbit

  • Chores
    • Improved the release workflow to correctly retrieve build artifacts, ensuring proper distribution of release packages.

@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8ea83ee0-8f45-4f70-a3e5-9346a6ff14d2

📥 Commits

Reviewing files that changed from the base of the PR and between 81e61f9 and 1263edb.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The GitHub Actions release workflow was modified to update the artifact download path in the "Download built dist" step, changing it to explicitly reference the dist directory instead of the current working directory.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/release.yml
Updated artifact download path to target dist directory instead of . in the release step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A path correction, so precise,
From dot to dist, a swift device,
The workflow gleams with clarity bright,
Our artifacts download just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions 'normalize dist layout' which aligns with the main objective of ensuring consistent dist structure, and references 'disable npm rebuild' which is a key change. However, the raw_summary only documents the artifact download path change, not the full scope of changes described in PR objectives. Clarify whether the title should reflect only the documented download path change or the full scope including npm rebuild and platform-specific normalization steps.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/run-release.yml-to-simulate-github-actions-8hwayv

Comment @coderabbitai help to get the list of available commands and usage tips.

@cita-777 cita-777 merged commit 95c7b5b into main Mar 6, 2026
4 checks passed
@github-actions github-actions bot added size: XXL 2000 or more lines changed area: ci CI, workflows, and deployment changes size: XS Less than 50 lines changed and removed size: XXL 2000 or more lines changed labels Mar 15, 2026
@cita-777 cita-777 deleted the codex/run-release.yml-to-simulate-github-actions-8hwayv branch March 15, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI, workflows, and deployment changes codex size: XS Less than 50 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant