Skip to content

Fix: Restore GitLabDSL.api to be GitLabAPI instance#1354

Closed
glensc wants to merge 1 commit intomainfrom
gitlab-api-expose
Closed

Fix: Restore GitLabDSL.api to be GitLabAPI instance#1354
glensc wants to merge 1 commit intomainfrom
gitlab-api-expose

Conversation

@glensc
Copy link
Copy Markdown
Contributor

@glensc glensc commented Feb 7, 2023

Revert "Ensures that the Gitlab API is exposed properly through the dts"

This reverts commit e8d2052.

The breakage introduced between 10.6.5 and 10.6.6 patch version update

Refs:

@glensc glensc self-assigned this Feb 7, 2023
@glensc glensc changed the title Restore GitLabDSL.api to be GitLabAPI instance Fix: Restore GitLabDSL.api to be GitLabAPI instance Feb 7, 2023
@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented Feb 15, 2023

I think there aren't many gitlab users that has gone un-noticed that long. at least the write methods.

I do use gitlab, not so far did not need to use write functions, just used danger.gitlab json structures

Revert "Ensures that the Gitlab API is exposed properly through the dts"

This reverts commit e8d2052.

The breakage is between 10.6.5 and 10.6.6 version
@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented Mar 1, 2023

@orta who can give insights and directions on how to the problem? only you?

@orta
Copy link
Copy Markdown
Member

orta commented Mar 2, 2023

Yep, I do OSS in my increasingly little spare time and so mainly only have time for well formed non-draft PRs

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented Jul 30, 2023

hmm. I can no longer update this branch

ERROR: Permission to danger/danger-js.git denied to glensc.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented Apr 12, 2026

Closing:

  1. Developer permissions revoked (can't update pr).
  2. No longer need this.

@glensc glensc closed this Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants