Open
Conversation
Author
|
If someone has this issue with Nasty but works. // This hack is required because filing-cabinet
// (a madge dependency) doesn't support .mjs files
// https://github.com/dependents/node-filing-cabinet/pull/128
import { readFile, writeFile } from 'fs/promises';
async function getHackedMadge() {
const file = await import.meta.resolve('filing-cabinet/index.js');
const content = await readFile(file, 'utf8');
if (!content.includes('.mjs')) {
const hacked = content.replace(
"'.jsx': jsLookup,",
(x) => `${x}\n '.mjs': jsLookup,`
);
await writeFile(file, hacked, 'utf8');
}
const module = await import('madge');
const madge = module.default ?? module.madge;
// @ts-ignore This is memoization
getHackedMadge = () => madge;
return madge;
}
// anywhere else
const madge = await getHackedMadge();
// following invocations are memoized
const madge2 = await getHackedMadge();
console.assert(madge === madge2) |
Member
|
By the same logic, shouldn't .cjs be supported too? Note that this needs a test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables proper dependency parsing for
.mjsfiles.