Add getLookup() API to allow composing custom lookup from internal lookup#136
Open
rmunch wants to merge 2 commits intodependents:mainfrom
Open
Add getLookup() API to allow composing custom lookup from internal lookup#136rmunch wants to merge 2 commits intodependents:mainfrom
rmunch wants to merge 2 commits intodependents:mainfrom
Conversation
Member
|
Please make sure tests pass, CI didn't run here for some reason. |
Member
|
@rmunch please update the docs to mention the change, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing to add a
getLookupAPI. For my use case, I have some proprietary paths in a stylesheet that are not handled by existing lookups. While I can register a custom lookup to resolve these proprietary paths, I only need to handle certain of those paths, and want to defer the rest to existing lookups. Currently, thetsLookupand some others aren't exported - rather than exporting those, I thought this solution could be more flexible and future-proof if new internal lookups are added.If this looks desirable, I can do another pass to update docs. Thanks!