This repository was archived by the owner on Mar 8, 2023. It is now read-only.
Merged
Conversation
cniska
added
enhancement
cniska
force-pushed
the
resolver-middleware
branch
2 times, most recently
from
8987fcc to
13a1124
Compare
Jalle19
reviewed
Oct 8, 2018
| return $resolver->getResolveCallback(); | ||
| } | ||
|
|
||
| if ($resolver instanceof \Closure) { |
Contributor
Author
There was a problem hiding this comment.
This is actually correct.
cniska
force-pushed
the
resolver-middleware
branch
from
13a1124 to
e0c0140
Compare
Jalle19
approved these changes
Oct 8, 2018
Contributor
Jalle19
left a comment
Jalle19
left a comment
There was a problem hiding this comment.
The code looks good, but some documentation would be great
cniska
force-pushed
the
resolver-middleware
branch
2 times, most recently
from
ed25b15 to
a81f6f5
Compare
spawnia
approved these changes
Oct 8, 2018
Contributor
spawnia
left a comment
spawnia
left a comment
There was a problem hiding this comment.
Looks pretty clean, i like it!
Is there a way to specify non-global middleware?
q-hung
approved these changes
Oct 8, 2018
cniska
force-pushed
the
resolver-middleware
branch
from
a81f6f5 to
0e639f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for resolver middleware.
This feature was inspired by graphql-middlware.