Conversation
|
@vcastellm Can you please help review, I can run localtest passed except for the AgentCommand for Election, I think that could be becouse of the macOS ENV issue, I suggest merge this to keep updated, because from any aspects the go v1.16 is too old. goroutine 34 [running]: goroutine 1 [chan receive, 10 minutes]: goroutine 20 [runnable]: goroutine 7 [runnable]: |
Makefile
Outdated
| ui: dkron/ui-dist | ||
|
|
||
| main: dkron/ui-dist plugin/types/dkron.pb.go plugin/types/executor.pb.go *.go */*.go */*/*.go */*/*/*.go | ||
| #main: dkron/ui-dist plugin/types/dkron.pb.go plugin/types/executor.pb.go *.go */*.go */*/*.go */*/*/*.go |
There was a problem hiding this comment.
It's for local test.
And sorry that I missed this message, a new pull request, please take a review.
|
@BrainGithub tests are passing in the CI |
Signed-off-by: zx <axpzhang@gmail.com>
BrainGithub
left a comment
There was a problem hiding this comment.
Look good to me.
I suggest merge this to keep updated.