Merged
Conversation
vcastellm
requested changes
Mar 12, 2025
Member
vcastellm
left a comment
vcastellm
left a comment
There was a problem hiding this comment.
Even though is good to have a PR template I want the PRs descriptions to stay lean and small, I usually hate too verbose PR templates forcing to fill multiple checkboxes that doesn't apply in most of the cases.
So my suggestion here would be to remove the checklists or reduce them to the minimum.
Contributor
Author
|
Sure, I'll reduce the clutter. |
vcastellm
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went ahead and added a PR template I use regularly to mainstream the PRs, so they should be a bit more readable and include the purpose and other information for a PR.