Skip to content

fix: Context timeout for Google Cloud PubSub#1685

Merged
vcastellm merged 1 commit intodkron-io:mainfrom
xBlaz3kx:fix/gcpubsub-timeout
Mar 12, 2025
Merged

fix: Context timeout for Google Cloud PubSub#1685
vcastellm merged 1 commit intodkron-io:mainfrom
xBlaz3kx:fix/gcpubsub-timeout

Conversation

@xBlaz3kx
Copy link
Copy Markdown
Contributor

@xBlaz3kx xBlaz3kx commented Mar 7, 2025

Added context timeout to prevent indefinite job execution for GC PubSub.
The PubSub client however has a keepalive of 5 minutes set, but that is way too much imo.

@xBlaz3kx xBlaz3kx changed the title Fix: Added context timeout for Google Cloud PubSub fix: Context timeout for Google Cloud PubSub Mar 8, 2025
Copy link
Copy Markdown
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx!

@vcastellm vcastellm merged commit c61483c into dkron-io:main Mar 12, 2025
1 check passed
@xBlaz3kx xBlaz3kx deleted the fix/gcpubsub-timeout branch March 12, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants