Add moderate way to retry docker login failures#849
Open
fedordikarev wants to merge 22 commits intodocker:masterfrom
Open
Add moderate way to retry docker login failures#849fedordikarev wants to merge 22 commits intodocker:masterfrom
fedordikarev wants to merge 22 commits intodocker:masterfrom
Conversation
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
Signed-off-by: Fedor Dikarev <fedor.dikarev@gmail.com>
fce3de6 to
810869f
Compare
Open
Closed
|
This is another potential condition where the registry fails to respond all together, for example when the connection times out/reset: Happens on self-hosted runners, in certain hosting providers across the Atlantic (not everyone lives in us-east-1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #750
Ref: https://github.com/neondatabase/cloud/issues/20164
Current problem:
that mechanism at the same time should be conservative, not adding extra unneeded load to DockerHub or another Registry, so for example we shouldn't retry "Bad credentials", we should have timeouts, and reasonable max_attempts
so with that approach:
Please let me know if it's good approach or if anything should be adjusted to be accepted