core: solve a remote-import/local-mine data race#2793
Merged
karalabe merged 1 commit intoethereum:developfrom Jul 12, 2016
karalabe:blockchain-import-mine-datarace
Merged
core: solve a remote-import/local-mine data race#2793karalabe merged 1 commit intoethereum:developfrom karalabe:blockchain-import-mine-datarace
karalabe merged 1 commit intoethereum:developfrom
karalabe:blockchain-import-mine-datarace
Conversation
Updated: Tue Jul 12 12:04:40 UTC 2016 |
2 tasks
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
blockchain.WriteBlockis a method used by the miner whenever it mints a new block to have it imported into the local chain. This method before acquiring the lock on the blockchain itself however retrieved the current total difficulty, for which it needed the current block's hash. Accessing the current block without a lock is a bit no-no, as it may concurrently be modified by a remote import.