fix(v2): useTOC hooks should not be called in each nested children#1959
Merged
fix(v2): useTOC hooks should not be called in each nested children#1959
Conversation
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit ed626cf |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit ed626cf |
Contributor
|
Deploy preview for docusaurus-2 ready! Built with commit 81be1ea |
Contributor
|
Deploy preview for docusaurus-preview ready! Built with commit 81be1ea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TOC hooks is called inside each nested children previously. See gif below on how many
getActiveHeaderwhich leads to document query calls.See recursive headings
docusaurus/packages/docusaurus-theme-classic/src/theme/DocItem/index.js
Lines 22 to 38 in 3be2e86
We should also do better in future by doing some throttling, but that's out of scope of this PR.
We can also split RightTOC component as another
@theme/RightTOCcomponent so its swizzle-able if needed (but better in future PR so that lerna autogenerated changelog can pick it better)Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
right toc still highlighted on scroll