feat(core): add --config param to swizzle command#8210
Merged
slorber merged 1 commit intofacebook:mainfrom Oct 20, 2022
Merged
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
reviewed
Oct 18, 2022
Collaborator
Josh-Cena
left a comment
There was a problem hiding this comment.
Maybe add a test with a different config? (I forgot if we have similar tests)
Contributor
Author
|
I did not see that this was tested anywhere else, but I'll add tests in a few days. |
Collaborator
|
yes we don't have test on other CLIs for now so that matches with our current practices 😅 LGTM thanks 👍 |
slorber
pushed a commit
that referenced
this pull request
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
My Docusaurus site uses a non-default config location and I am unable to use swizzle.
Test Plan
Because swizzle is not currently working out of the box on main, I've applied this additional diff for the sake of the test.
website/docusaurus.config.jstowebsite/cfg.js.yarn swizzle --config cfg.js.Test links
N/A
Related issues/PRs