Remove plexus-utils from firebase-database's test dependency#4233
Merged
vkryachko merged 1 commit intofirebase:masterfrom Oct 27, 2022
Merged
Remove plexus-utils from firebase-database's test dependency#4233vkryachko merged 1 commit intofirebase:masterfrom
vkryachko merged 1 commit intofirebase:masterfrom
Conversation
firebase-database only uses StringUtils#repeat in test code, and it is easy to port repeat method to test file and remove plexus-utils from test dependency. Signed-off-by: utzcoz <utzcoz@outlook.com>
Contributor
Author
|
Hi @thatfiredev, @vkryachko, could you help to review this PR? Thanks. |
maneesht
approved these changes
Oct 22, 2022
Contributor
maneesht
left a comment
maneesht
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
Contributor
Author
|
Hi @maneesht thanks for you reviewing. Is there any updates of this PR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firebase-database only uses
StringUtils#repeatin test code, and it is easy to port repeat method to test file and remove plexus-utils from test dependency.