Update CHANGELOG entries across several sdks#4240
Merged
Conversation
Collaborator
Coverage Report 1This report is too large (76,790 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
Collaborator
Size Report 1Affected ProductsNo changes between base commit (ae3bdb8) and merge commit (92af3da).Test Logs |
Collaborator
Author
|
friendly ping |
daymxn
reviewed
Oct 27, 2022
| @@ -1,7 +1,15 @@ | |||
| # Unreleased | |||
daymxn
reviewed
Oct 27, 2022
| * [fixed] Fixed an issue where `FirebaseModelDownloader.getModel` was throwing | ||
| `FirebaseMlException.PERMISSION_DENIED` when the model name was empty. It now | ||
| throws `FirebaseMlException.INVALID_ARGUMENT` | ||
| (#4157) |
Member
There was a problem hiding this comment.
Are these also supposed to be links btw?
daymxn
approved these changes
Oct 27, 2022
Member
daymxn
left a comment
daymxn
left a comment
There was a problem hiding this comment.
LGTM, although would you mind pinging me in gc with the tooling that interprets this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.