Add Dackka transform to remove leading groupId in Javadocs#4278
Merged
Add Dackka transform to remove leading groupId in Javadocs#4278
Conversation
Contributor
Contributor
Collaborator
Size Report 1Affected ProductsNo changes between base commit (f6a79df) and merge commit (07fa659).Test Logs |
rlazo
approved these changes
Nov 3, 2022
davidmotson
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Add groupId removal transform * Add bug link for dackka exposing the configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per b/257073544, this PR adds a transform to
FiresiteTransformthat removes the leadingcom.googlefrom our YAML files. This is fine for our kdoc files, but from the javadoc perspective it looks a bit odd as other internal tooling follows the same format (docs that are generated outside the scope ofDackkaPlugin).This also removes the old transform for removing the leading Firebase domain from links- as it's no longer needed (see #4258).