Avoid throwing in ForcedSender.sendBlocking#4293
Merged
Conversation
…en a wrong Transport type. This will make it easier to mock Transport in tests. This method is best-effort anyway, so doing nothing instead of throwing is fine.
Collaborator
Coverage Report 1Affected Products
Test Logs |
Contributor
Collaborator
Size Report 1Affected Products
Test Logs |
vkryachko
reviewed
Nov 10, 2022
| ((TransportImpl<?>) transport).getTransportContext().withPriority(priority); | ||
| TransportRuntime.getInstance().getUploader().logAndUpdateState(context, 1); | ||
| } | ||
| throw new IllegalArgumentException("Expected instance of TransportImpl."); |
Member
There was a problem hiding this comment.
Let's add a warning log statement here, there's logging util available in this sdk under
com.google.android.datatransport.runtime.logging.Logging
vkryachko
approved these changes
Nov 14, 2022
davidmotson
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Make ForcedSender.sendBlocking do nothing, instead of throw, when given a wrong Transport type. This will make it easier to mock Transport in tests. This method is best-effort anyway, so doing nothing instead of throwing is fine. * Log warning when given wrong type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ForcedSender.sendBlocking do nothing, instead of throw, when given a wrong Transport type.
This will make it easier to mock Transport in tests. This method is best-effort anyway, so doing nothing instead of throwing is fine.