Add option to allow SDK create cache indexes automatically to improve query execution locally by cherylEnkidu · Pull Request #4987 · firebase/firebase-android-sdk

cherylEnkidu · 2023-05-08T04:24:37Z

Preparing work for index auto creation feature.

This PR was ported to the web sdk in firebase/firebase-js-sdk#7542.

github-actions · 2023-05-08T04:24:52Z

Javadoc Changes:

--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-26 17:30:50.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-26 17:24:33.000000000 +0000
@@ -22,6 +22,27 @@
         </colgroup>
         <thead>
           <tr>
+            <th colspan="100%"><h3>Public fields</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a></code></td>
+            <td>
+              <div><code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#persistentCacheIndexManager()">persistentCacheIndexManager</a></code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
             <th colspan="100%"><h3>Public methods</h3></th>
           </tr>
         </thead>
@@ -233,6 +254,13 @@
       </table>
     </div>
     <div class="list">
+      <h2>Public fields</h2>
+      <div class="api-item"><a name="getPersistentCacheIndexManager()"></a><a name="setPersistentCacheIndexManager()"></a><a name="getPersistentCacheIndexManager--"></a><a name="setPersistentCacheIndexManager--"></a>
+        <h3 class="api-name" id="persistentCacheIndexManager()">persistentCacheIndexManager</h3>
+        <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#persistentCacheIndexManager()">persistentCacheIndexManager</a></pre>
+      </div>
+    </div>
+    <div class="list">
       <h2>Public methods</h2>
       <div class="api-item"><a name="addSnapshotsInSyncListener-java.lang.Runnable-"></a><a name="addsnapshotsinsynclistener"></a>
         <h3 class="api-name" id="addSnapshotsInSyncListener(java.lang.Runnable)">addSnapshotsInSyncListener</h3>

--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-26 17:30:50.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-26 17:24:32.000000000 +0000
@@ -232,6 +232,27 @@
         </tbody>
       </table>
     </div>
+    <div class="devsite-table-wrapper">
+      <table class="responsive">
+        <colgroup>
+          <col width="40%">
+          <col>
+        </colgroup>
+        <thead>
+          <tr>
+            <th colspan="100%"><h3>Public properties</h3></th>
+          </tr>
+        </thead>
+        <tbody class="list">
+          <tr>
+            <td><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a>?</code></td>
+            <td>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#persistentCacheIndexManager()">persistentCacheIndexManager</a></code></div>
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    </div>
     <div class="list">
       <h2>Public functions</h2>
       <div class="api-item"><a name="addSnapshotsInSyncListener-java.lang.Runnable-"></a><a name="addsnapshotsinsynclistener"></a>
@@ -1211,6 +1232,13 @@
         </div>
       </div>
     </div>
+    <div class="list">
+      <h2>Public properties</h2>
+      <div class="api-item"><a name="getPersistentCacheIndexManager()"></a><a name="setPersistentCacheIndexManager()"></a><a name="getPersistentCacheIndexManager--"></a><a name="setPersistentCacheIndexManager--"></a>
+        <h3 class="api-name" id="persistentCacheIndexManager()">persistentCacheIndexManager</h3>
+        <pre class="api-signature no-pretty-print">val&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#persistentCacheIndexManager()">persistentCacheIndexManager</a>:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/PersistentCacheIndexManager.html">PersistentCacheIndexManager</a>?</pre>
+      </div>
+    </div>
   </body>
 </html>

google-oss-bot · 2023-05-08T04:31:32Z

Coverage Report ¹

Affected Products

`firebase-firestore`

Overall coverage changed from 44.35% (fc5cde4) to 44.47% (8093125) by +0.12%.

13 individual files with coverage change

Filename	Base (`fc5cde4`)	Merge (`8093125`)	Diff
AutoValue_FieldIndex_IndexOffset.java	58.62%	55.17%	-3.45%
FirebaseFirestore.java	38.25%	37.04%	-1.21%
FirestoreClient.java	36.11%	35.37%	-0.74%
LruGarbageCollector.java	97.27%	93.64%	-3.64%
MemoryIndexManager.java	68.97%	66.67%	-2.30%
MemoryRemoteDocumentCache.java	98.28%	98.31%	+0.03%
PatchMutation.java	100.00%	98.39%	-1.61%
PersistentCacheIndexManager.java	?	0.00%	?
QueryContext.java	?	100.00%	?
QueryEngine.java	98.63%	99.02%	+0.39%
SQLiteIndexManager.java	99.49%	99.50%	+0.01%
SQLiteRemoteDocumentCache.java	98.21%	98.31%	+0.09%
TargetIndexMatcher.java	100.00%	97.78%	-2.22%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/thMDSMFTXj.html

github-actions · 2023-05-08T04:34:33Z

Unit Test Results

  162 files +  108   162 suites +108 2m 44s ⏱️ - 4m 21s
1 188 tests +  718 1 172 ✔️ +  702 16 💤 +16 0 ❌ ±0
2 376 runs +1 436 2 344 ✔️ +1 404 32 💤 +32 0 ❌ ±0

Results for commit fb12477. ± Comparison against base commit 4d1cc39.

This pull request removes 470 and adds 1188 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2023-05-08T04:42:55Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (fc5cde4) Merge (8093125) Diff
aar 1.36 MB 1.36 MB +3.69 kB (+0.3%)
apk (release) 3.95 MB 3.95 MB +2.24 kB (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/bGsGrjWIm8.html

google-oss-bot · 2023-05-08T05:01:00Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (fc5cde4) and the CI merge commit (8093125)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- fc5cde4: https://storage.googleapis.com/firebase-sdk-metric-reports/SRK3xwXvRN/index.html
- 8093125: https://storage.googleapis.com/firebase-sdk-metric-reports/XcKcrEaQjD/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`fc5cde4`	`8093125`	Diff	Significant (?)
p10	324 ±18 μs	316 ±12 μs	-7.82 μs (-2.4%)	NO
p25	341 ±23 μs	327 ±15 μs	-13.9 μs (-4.1%)	NO
p50	370 ±41 μs	345 ±24 μs	-25.6 μs (-6.9%)	NO
p75	436 ±73 μs	403 ±74 μs	-33.0 μs (-7.6%)	NO
p90	523 ±126 μs	479 ±95 μs	-44.9 μs (-8.6%)	NO

20 test runs in comparison

Commit	Test Runs
`fc5cde4`	2023-07-26_15:12:33.900360_wSfj 2023-07-26_15:12:33.905569_ojoz 2023-07-26_15:12:33.905583_UFLj 2023-07-26_15:12:33.905590_Tuns 2023-07-26_15:12:33.905596_YiIP 2023-07-26_15:12:33.905603_LwJo 2023-07-26_15:12:33.905610_GOAh 2023-07-26_15:12:33.905616_TVTP 2023-07-26_15:12:33.905621_AXaX 2023-07-26_15:12:33.905630_nbIy
`8093125`	2023-07-26_17:36:22.067399_WwtC 2023-07-26_17:36:22.072489_QqzG 2023-07-26_17:36:22.072538_JevK 2023-07-26_17:36:22.072558_mvSw 2023-07-26_17:36:22.072575_Jzfo 2023-07-26_17:36:22.072591_Ipnq 2023-07-26_17:36:22.072608_TzMg 2023-07-26_17:36:22.072622_tRtH 2023-07-26_17:36:22.072637_jsIq 2023-07-26_17:36:22.072659_OlMe

redfin-30

Percentile	`fc5cde4`	`8093125`	Diff	Significant (?)
p10	614 ±36 μs	588 ±16 μs	-25.9 μs (-4.2%)	NO
p25	633 ±42 μs	601 ±18 μs	-31.9 μs (-5.0%)	NO
p50	661 ±54 μs	620 ±24 μs	-41.3 μs (-6.2%)	NO
p75	693 ±66 μs	644 ±32 μs	-49.2 μs (-7.1%)	NO
p90	732 ±83 μs	682 ±45 μs	-49.6 μs (-6.8%)	NO

20 test runs in comparison

Commit	Test Runs
`fc5cde4`	2023-07-26_15:12:33.900360_wSfj 2023-07-26_15:12:33.905569_ojoz 2023-07-26_15:12:33.905583_UFLj 2023-07-26_15:12:33.905590_Tuns 2023-07-26_15:12:33.905596_YiIP 2023-07-26_15:12:33.905603_LwJo 2023-07-26_15:12:33.905610_GOAh 2023-07-26_15:12:33.905616_TVTP 2023-07-26_15:12:33.905621_AXaX 2023-07-26_15:12:33.905630_nbIy
`8093125`	2023-07-26_17:36:22.067399_WwtC 2023-07-26_17:36:22.072489_QqzG 2023-07-26_17:36:22.072538_JevK 2023-07-26_17:36:22.072558_mvSw 2023-07-26_17:36:22.072575_Jzfo 2023-07-26_17:36:22.072591_Ipnq 2023-07-26_17:36:22.072608_TzMg 2023-07-26_17:36:22.072622_tRtH 2023-07-26_17:36:22.072637_jsIq 2023-07-26_17:36:22.072659_OlMe

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`fc5cde4`	`8093125`	Diff	Significant (?)
p10	201 ±5 ms	203 ±2 ms	+1.94 ms (+1.0%)	NO
p25	207 ±5 ms	210 ±2 ms	+2.63 ms (+1.3%)	NO
p50	214 ±6 ms	218 ±2 ms	+3.27 ms (+1.5%)	NO
p75	222 ±6 ms	227 ±4 ms	+4.54 ms (+2.0%)	NO
p90	230 ±7 ms	239 ±5 ms	+8.79 ms (+3.8%)	NO

20 test runs in comparison

Commit	Test Runs
`fc5cde4`	2023-07-26_15:12:33.900360_wSfj 2023-07-26_15:12:33.905569_ojoz 2023-07-26_15:12:33.905583_UFLj 2023-07-26_15:12:33.905590_Tuns 2023-07-26_15:12:33.905596_YiIP 2023-07-26_15:12:33.905603_LwJo 2023-07-26_15:12:33.905610_GOAh 2023-07-26_15:12:33.905616_TVTP 2023-07-26_15:12:33.905621_AXaX 2023-07-26_15:12:33.905630_nbIy
`8093125`	2023-07-26_17:36:22.067399_WwtC 2023-07-26_17:36:22.072489_QqzG 2023-07-26_17:36:22.072538_JevK 2023-07-26_17:36:22.072558_mvSw 2023-07-26_17:36:22.072575_Jzfo 2023-07-26_17:36:22.072591_Ipnq 2023-07-26_17:36:22.072608_TzMg 2023-07-26_17:36:22.072622_tRtH 2023-07-26_17:36:22.072637_jsIq 2023-07-26_17:36:22.072659_OlMe

redfin-30

Percentile	`fc5cde4`	`8093125`	Diff	Significant (?)
p10	245 ±4 ms	262 ±7 ms	+17.6 ms (+7.2%)	NO
p25	252 ±5 ms	268 ±6 ms	+15.8 ms (+6.3%)	NO
p50	259 ±5 ms	275 ±6 ms	+16.4 ms (+6.3%)	NO
p75	267 ±5 ms	286 ±6 ms	+19.2 ms (+7.2%)	MAYBE
p90	278 ±5 ms	301 ±6 ms	+23.0 ms (+8.3%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`fc5cde4`	2023-07-26_15:12:33.900360_wSfj 2023-07-26_15:12:33.905569_ojoz 2023-07-26_15:12:33.905583_UFLj 2023-07-26_15:12:33.905590_Tuns 2023-07-26_15:12:33.905596_YiIP 2023-07-26_15:12:33.905603_LwJo 2023-07-26_15:12:33.905610_GOAh 2023-07-26_15:12:33.905616_TVTP 2023-07-26_15:12:33.905621_AXaX 2023-07-26_15:12:33.905630_nbIy
`8093125`	2023-07-26_17:36:22.067399_WwtC 2023-07-26_17:36:22.072489_QqzG 2023-07-26_17:36:22.072538_JevK 2023-07-26_17:36:22.072558_mvSw 2023-07-26_17:36:22.072575_Jzfo 2023-07-26_17:36:22.072591_Ipnq 2023-07-26_17:36:22.072608_TzMg 2023-07-26_17:36:22.072622_tRtH 2023-07-26_17:36:22.072637_jsIq 2023-07-26_17:36:22.072659_OlMe

https://storage.googleapis.com/firebase-sdk-metric-reports/tczw3eSsBV/index.html

wu-hui

Some comments, I think you get the overall idea however.

While you are at it, maybe write a simple count-based heuristics: compare the doc reads from full collection scan, and indexed-doc reads from a imaginary perfect indexed query, and make a decision to turn on indexing?

firebase-firestore/src/main/java/com/google/firebase/firestore/local/AutoIndexing.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java

google-oss-bot · 2023-05-17T02:34:35Z

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.PersistentCacheSettings.autoClientIndexingEnabled() [AddedMethod]
error: Added method com.google.firebase.firestore.PersistentCacheSettings.Builder.enableAutoClientIndexing(boolean) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

wu-hui

Looks good for a prototype.

I want to see some tests for the change in TargetIndexMatcher, then we should be able to move forward.

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteIndexManager.java

firebase-firestore/src/main/java/com/google/firebase/firestore/model/TargetIndexMatcher.java

google-oss-bot · 2023-05-24T04:50:30Z

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.PersistentCacheSettings.autoClientIndexingEnabled() [AddedMethod]
error: Added method com.google.firebase.firestore.PersistentCacheSettings.Builder.enableAutoClientIndexing(boolean) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2023-05-25T15:08:13Z

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.PersistentCacheSettings.autoClientIndexingEnabled() [AddedMethod]
error: Added method com.google.firebase.firestore.PersistentCacheSettings.Builder.enableAutoClientIndexing(boolean) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

firebase-firestore/src/main/java/com/google/firebase/firestore/model/TargetIndexMatcher.java

google-oss-bot · 2023-06-27T03:37:27Z

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.getPersistentCacheIndexManager() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2023-06-27T03:40:12Z

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.getPersistentCacheIndexManager() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

google-oss-bot · 2023-06-27T03:40:23Z

The public api surface has changed for the subproject firebase-firestore:
error: Added method com.google.firebase.firestore.FirebaseFirestore.getPersistentCacheIndexManager() [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

wu-hui

Please add more tests to SQLiteLocalStoreTest.

This is a place where you can:

setup a collection
turn on auto-indexing
run a query that should have added a field index
verify field indexes are added
call backfillIndexes()
verify query result and document read count is as expected as an indexed query.

You should be able to find enough examples in that file.

firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalDocumentsView.java

firebase-firestore/src/main/java/com/google/firebase/firestore/PersistentCacheIndexManager.java

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/IndexingTest.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteIndexManager.java

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java

firebase-firestore/src/main/java/com/google/firebase/firestore/PersistentCacheIndexManager.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

firebase-firestore/src/main/java/com/google/firebase/firestore/model/TargetIndexMatcher.java

wu-hui

Some improvements are still needed, but I think we are very close now.

firebase-firestore/src/main/java/com/google/firebase/firestore/PersistentCacheIndexManager.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalDocumentsView.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

firebase-firestore/src/test/java/com/google/firebase/firestore/local/SQLiteLocalStoreTest.java

wu-hui

LGTM with some nits.

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

dconeybe

Thank you for addressing my previous comments. After re-reading, I have some more suggestions, mostly relating to readability rather than to functionality of the code.

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

...e-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteRemoteDocumentCache.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

dconeybe

Just a few final comments, but LGTM for the most part.

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

firebase-firestore/src/main/java/com/google/firebase/firestore/FirebaseFirestore.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryContext.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/MemoryIndexManager.java

firebase-firestore/src/main/java/com/google/firebase/firestore/local/QueryEngine.java

… query execution locally (#4987) * Add counter * address feedback 1 * add copyright * fix concurrency bug * implement autoClientIndexing * Add tests and fix bugs for BuildTargetIndex * hide getter from public API * move the flag from IndexManager to QueryEngine * Address feedback * move auto index flag to runtime * Support old way to enable persistent for PersistentCacheManager * Polish Tests * Add hide and copyright * clean up unused function * Rename PersistentCacheManager to PersistentCacheIndexManager * Remove unused QueryContext * Address feedbacks other than adding tests and comments * Change the api to match the update * Add tests * Increase tests coverage * Add comments * add configurable min documents to create indexes * Address Denver's feedback * Address feedback * address more feedbacks * use the number getting from 100 ~ 1000 documents experiment * Address feedbacks * improve debug log

google-oss-bot added the size/L label May 8, 2023

wu-hui reviewed May 9, 2023

View reviewed changes

cherylEnkidu force-pushed the cheryllin/autoindexing branch from 79b1fd2 to 8aed796 Compare May 17, 2023 04:05

wu-hui reviewed May 18, 2023

View reviewed changes

wu-hui reviewed May 25, 2023

View reviewed changes

firebase-firestore/src/main/java/com/google/firebase/firestore/model/TargetIndexMatcher.java Show resolved Hide resolved

google-oss-bot added size/XL and removed size/L labels Jun 26, 2023

cherylEnkidu force-pushed the cheryllin/autoindexing branch 2 times, most recently from e5b8859 to 1e25c19 Compare June 27, 2023 03:28

firebase deleted a comment from google-oss-bot Jun 27, 2023

cherylEnkidu force-pushed the cheryllin/autoindexing branch 3 times, most recently from d48504b to ad7fc61 Compare June 27, 2023 15:23

cherylEnkidu assigned wu-hui Jun 28, 2023

wu-hui requested changes Jun 30, 2023

View reviewed changes

wu-hui assigned cherylEnkidu Jun 30, 2023

dconeybe requested changes Jul 18, 2023

View reviewed changes

cherylEnkidu added 2 commits July 19, 2023 12:25

add configurable min documents to create indexes

39756f4

Address Denver's feedback

3f7a970

wu-hui reviewed Jul 20, 2023

View reviewed changes

wu-hui assigned cherylEnkidu and unassigned wu-hui Jul 20, 2023

Address feedback

48d649f

cherylEnkidu assigned wu-hui and dconeybe and unassigned cherylEnkidu Jul 24, 2023

wu-hui approved these changes Jul 24, 2023

View reviewed changes

dconeybe requested changes Jul 24, 2023

View reviewed changes

dconeybe assigned cherylEnkidu and unassigned dconeybe Jul 24, 2023

cherylEnkidu mentioned this pull request Jul 24, 2023

Auto index Creation Experiment #5064

Closed

cherylEnkidu added 2 commits July 25, 2023 12:31

address more feedbacks

6c6698e

use the number getting from 100 ~ 1000 documents experiment

0336972

dconeybe requested changes Jul 25, 2023

View reviewed changes

Address feedbacks

46cfa2f

cherylEnkidu assigned dconeybe and unassigned wu-hui and cherylEnkidu Jul 26, 2023

improve debug log

fb12477

dconeybe approved these changes Jul 26, 2023

View reviewed changes

cherylEnkidu enabled auto-merge (squash) July 26, 2023 22:08

cherylEnkidu merged commit a5e7062 into master Jul 26, 2023

cherylEnkidu deleted the cheryllin/autoindexing branch July 26, 2023 22:12

dconeybe mentioned this pull request Aug 10, 2023

Firestore: enable/disablePersistentCacheIndexAutoCreation() added, but hidden for now firebase/firebase-js-sdk#7542

Merged

firebase locked and limited conversation to collaborators Aug 26, 2023

Conversation

cherylEnkidu commented May 8, 2023 • edited by dconeybe Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Results

Uh oh!

google-oss-bot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

google-oss-bot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

wu-hui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented May 17, 2023

Uh oh!

wu-hui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-oss-bot commented May 24, 2023

Uh oh!

google-oss-bot commented May 25, 2023

Uh oh!

Uh oh!

google-oss-bot commented Jun 27, 2023

Uh oh!

google-oss-bot commented Jun 27, 2023

Uh oh!

google-oss-bot commented Jun 27, 2023

Uh oh!

wu-hui left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cherylEnkidu commented May 8, 2023 •

edited by dconeybe

Loading

github-actions bot commented May 8, 2023 •

edited

Loading

google-oss-bot commented May 8, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented May 8, 2023 •

edited

Loading

google-oss-bot commented May 8, 2023 •

edited

Loading

Size Report ¹

`firebase-firestore`

google-oss-bot commented May 8, 2023 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`