Replace Category string with Categories []string#116
Open
gmalmquist wants to merge 1 commit intogorilla:mainfrom
Open
Replace Category string with Categories []string#116gmalmquist wants to merge 1 commit intogorilla:mainfrom
Category string with Categories []string#116gmalmquist wants to merge 1 commit intogorilla:mainfrom
Conversation
Both RSS and Atom support multiple categories on feeds and entries, per their respective specifications. This branch supports that, and additionally plumbs the categories field through to both RSS and Atom variants. This addresses issue gorilla#77, which has as of writing been closed as stale without actually being fixed. *This change is breaking.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both RSS and Atom support multiple categories on feeds and entries, per their respective specifications. This branch supports that, and additionally plumbs the categories field through to both RSS and Atom variants. This addresses issue #77, which has as of writing been closed as stale without actually being fixed.
This change is breaking.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing