fix idfgh-6508: return type in tu_fifo_peek_n()#1287
Merged
hathach merged 1 commit intohathach:masterfrom Jan 19, 2022
Merged
Conversation
hathach
approved these changes
Jan 19, 2022
Owner
hathach
left a comment
hathach
left a comment
There was a problem hiding this comment.
spot-on, thank you for the bug fix. I was probably writing this while sleepy
Contributor
Author
|
Thank you for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This simple PR is submitted to fix the IDFGH-6508 issue as described here: espressif/esp-idf#8161
The return type in the line /src/common/tusb_fifo.c:719 should be changed to
uint16_tinstead of bool.The esp-idf fork then can be rebased on upstream master.