Skip to content

in TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR, _nitfs should be 3.#1360

Merged
hathach merged 1 commit intohathach:masterfrom
ccrome:uac2_headset_descriptor_update
Mar 9, 2022
Merged

in TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR, _nitfs should be 3.#1360
hathach merged 1 commit intohathach:masterfrom
ccrome:uac2_headset_descriptor_update

Conversation

@ccrome
Copy link
Copy Markdown
Contributor

@ccrome ccrome commented Mar 2, 2022

I believe that there is a mistake in the definition of TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR. The nitfs in the audio descriptor is always 3 regardless of ITF_NUM_TOTAL.

Describe the PR
I change the number of interfaces to 3, so that I could add a CDC descriptor after, and it worked without complaints from Linux.

I believe that there is a mistake in the definition of TUD_AUDIO_HEADSET_STEREO_DESCRIPTOR.  The nitfs in the audio descriptor is always 3 regardless of ITF_NUM_TOTAL.
Copy link
Copy Markdown
Collaborator

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccrome You are right, it should be 3 as this examples clearly has 3 interfaces (control/speaker/microphone). My bad.

@hathach
Copy link
Copy Markdown
Owner

hathach commented Mar 9, 2022

great work, thank you for your fix

@hathach hathach merged commit 0d8be7f into hathach:master Mar 9, 2022
@ccrome
Copy link
Copy Markdown
Contributor Author

ccrome commented Mar 11, 2022

You're welcome.... took me a bit to track down when I added a CDC device to my audio device. Thanks for the awesome library and examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants