UAC2: fix feedback EP buffer alignment.#1965
Merged
hathach merged 1 commit intohathach:masterfrom Mar 21, 2023
Merged
Conversation
hathach
reviewed
Mar 21, 2023
src/class/audio/audio_device.c
Outdated
| }compute; | ||
|
|
||
| } feedback; | ||
| CFG_TUSB_MEM_ALIGN uint32_t feedback_value; // Feedback value for asynchronous mode (in 16.16 format). |
Owner
There was a problem hiding this comment.
we can put the CFG_TUSB_MEM_ALIGN to the struct feedback, which will make the value as 1st member to be aligned correctly ?
Collaborator
Author
There was a problem hiding this comment.
Yes that will work. I was thinking to avoid aligment on struct member so I moved value outside, but it should be ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Which cause error in
get_buf_offset()of lpc_ip3511.