fix(ncm): Use IN buffer for transmit checks#2947
Merged
HiFiPhile merged 1 commit intohathach:masterfrom Jan 15, 2025
Merged
Conversation
Contributor
Author
|
@HiFiPhile Either I'm missing something or this should be a very easy fix :) |
HiFiPhile
approved these changes
Jan 15, 2025
Collaborator
|
Thank you, somehow I missed it when testing... |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
CFG_TUD_NCM_OUT_NTB_MAX_SIZE is used instead of CFG_TUD_NCM_IN_NTB_MAX_SIZE in some asserts and length checks in transmit (IN) functions