fix: resolve the access key to the secret value#3207
Merged
Conversation
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
BruceMacD
approved these changes
Sep 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The access key being used for the getJWK call to the server was being used directly from the command line options. If a user specified a value of
env:...orfile:...then the connector would have sent the wrong value for the access key.This PR fixes the problem by first resolve the access key to the value stored in secrets, and using that as the value for the auth header.
Not entirely sure how to write a test for this since we can't easily run the connector in isolation until #2613 is merged.