feat: display organization names in previously logged in list#3234
Merged
kimskimchi merged 9 commits intomainfrom Sep 20, 2022
Merged
feat: display organization names in previously logged in list#3234kimskimchi merged 9 commits intomainfrom
kimskimchi merged 9 commits intomainfrom
Conversation
hoyyeva
reviewed
Sep 19, 2022
ui/pages/login/organizations.js
Outdated
| key={o.url} | ||
| className='my-2 inline-flex w-full items-center justify-between rounded-md border border-gray-300 bg-white py-2.5 px-4 text-xs text-gray-500 shadow-sm hover:bg-gray-100 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2' | ||
| > | ||
| {o.name} |
Contributor
There was a problem hiding this comment.
lets style this a little bit
maybe we can convert this whole <a /> to an <button />
something like this - you might want to play around a bit though
<button onClick={...} key={o.url} title={${o.name} — ${o.url}} className='my-2 inline-flex w-full items-center rounded-md border border-gray-300 bg-white py-2.5 px-4 shadow-sm hover:bg-gray-100 focus:outline-none focus:ring-2 focus:ring-blue-500 focus:ring-offset-2' > <div className='text-xs text-gray-500'>{o.name}</div> <div className='text-2xs text-gray-400'>{o.url}</div> </button>
Contributor
There was a problem hiding this comment.
Excited to see what this looks like
kimskimchi
requested review from
BruceMacD,
dnephin,
pdevine and
ssoroka
as code owners
BruceMacD
reviewed
Sep 20, 2022
BruceMacD
reviewed
Sep 20, 2022
BruceMacD
approved these changes
Sep 20, 2022
Collaborator
BruceMacD
left a comment
BruceMacD
left a comment
There was a problem hiding this comment.
Back-end change looks good
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
Co-authored-by: Bruce MacDonald <brucewmacdonald@gmail.com>
hoyyeva
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display organization names on the list of previously visited organization login pages.