Use a transaction in the migration test#3329
Merged
Conversation
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
mxyng
approved these changes
Sep 26, 2022
mxyng
reviewed
Sep 26, 2022
| { | ||
| label: testCaseLine("202206281027"), | ||
| setup: func(t *testing.T, db WriteTxn) { | ||
| t.Skip("this migration no longer works with transactions") |
Collaborator
There was a problem hiding this comment.
Should add a TODO here to fix later
Contributor
Author
There was a problem hiding this comment.
Ya, I wonder if we should fix this, or remove it since it's an old migration.
BruceMacD
approved these changes
Sep 26, 2022
Collaborator
BruceMacD
left a comment
BruceMacD
left a comment
There was a problem hiding this comment.
tested and validated locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3157 added a transaction for migrations, but I missed adding it to the test function.
This PR adds a transaction for each test case. I used a separate transaction for
migrateandexpectedbecause using the same transaction seem to produce a different error than the one we saw in production. This transaction setup should match production, because we commit the transaction used for migrations before performing any other query.Includes some fixes that will likely be merged before this, so I'll rebase once those are in.