Merged
Conversation
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
dnephin
force-pushed
the
dnephin/migration-test-check-missing-cleanup
branch
2 times, most recently
from
68643a6 to
0caf9cf
Compare
dnephin
commented
Sep 27, 2022
| stmts, err := schema.TrimComments(data) | ||
| assert.NilError(t, err) | ||
|
|
||
| if !assert.Check(t, is.Equal(stmts, "")) { |
Contributor
Author
There was a problem hiding this comment.
This line here should print something like this when it finds stale data:
--- stmts
+++ →
@@ -1,3 +1 @@
-INSERT INTO testing.identities_groups VALUES (1003, 1001);
-INSERT INTO testing.identities_groups VALUES (1004, 1002);
BruceMacD
approved these changes
Sep 27, 2022
Collaborator
BruceMacD
left a comment
BruceMacD
left a comment
There was a problem hiding this comment.
This fixes what I ran into, thanks
To ensure each test case does the necessary cleanup.
Co-authored-by: Michael Yang <michael.yang@infrahq.com>
mxyng
approved these changes
Sep 28, 2022
dnephin
force-pushed
the
dnephin/migration-test-check-missing-cleanup
branch
from
31d918e to
052d3c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that we don't leave stale test data in the database, which could cause subsequent test cases to fail.
Also adds a missing
DELETEto cleanup some stale entries from an existing test case.