Add unique constraint to destination name#3392
Merged
Conversation
dnephin
force-pushed
the
dnephin/destination-name-unique
branch
2 times, most recently
from
55c0e89 to
1af5072
Compare
BruceMacD
approved these changes
Oct 6, 2022
dnephin
force-pushed
the
dnephin/destination-name-dots
branch
from
345848a to
cec7782
Compare
dnephin
force-pushed
the
dnephin/destination-name-unique
branch
from
1af5072 to
2ee4988
Compare
dnephin
force-pushed
the
dnephin/destination-name-unique
branch
from
2ee4988 to
094f3cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #3276
This PR adds a unique constraint to destination name. The destination name must be unique because it is referred to be both grants in the
resourcefield, and by users when runninginfra use. A non-unique name makes both the grants and theuseambiguous and will likely cause problems.