Merged
Conversation
dnephin
force-pushed
the
dnephin/email-testing
branch
from
40022b0 to
65ad1ae
Compare
Add assertions for expected values of rendered email.
So that the test is closer to the production flow.
dnephin
force-pushed
the
dnephin/email-testing
branch
from
65ad1ae to
7635f5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was looking to make a change to some date formatting in one of the emails (to move it out of the
datapackage), but I noticed that the change I was going to make would not be covered by tests.This PR improves our test coverage for sending emails by:
The expected values here will change, and can automatically be updated by running the tests with
-update. The value here is that we get to preview the source of the email, and we'll catch unintended changes to the template.