Merged
Conversation
dnephin
requested review from
BruceMacD,
jmorganca and
pdevine
as code owners
mxyng
approved these changes
Oct 17, 2022
BruceMacD
approved these changes
Oct 17, 2022
Without this migration we can't list grants because it fails to load a nil into an int64.
dnephin
force-pushed
the
dnephin/fix-default-update-index
branch
from
be55660 to
df8819e
Compare
Contributor
Author
|
I updated the default value to 2. We return a By using a value of 2 a client that passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this migration we can't list grants because it fails to load a nil into an int64.
The test added in this PR fails with the following when the migration implementation was missing:
It passes with the new migration