Merged
Conversation
ssoroka
requested review from
BruceMacD,
dnephin,
jmorganca,
mchiang0610,
pdevine and
technovangelist
as code owners
BruceMacD
reviewed
Nov 3, 2022
Contributor
Author
|
@dnephin resolved your comments on the function arguments |
dnephin
approved these changes
Nov 4, 2022
Contributor
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
Nice! Looks good. A few suggestions, but nothing blocking. Would be fine as follow ups.
I still think that SetupBackgroundJobs and the jobs package create unnecessary indirection that hurts readability, but not worth blocking over it.
Comment on lines
+14
to
+63
| prt, err := CreatePasswordResetToken(tx, &models.Identity{Model: models.Model{ID: uid.New()}}, 0) | ||
| assert.NilError(t, err) |
Contributor
There was a problem hiding this comment.
Not a blocker, but I've been trying to create records that won't be deleted in these tests, to show that the filter behaves properly and leaves non-expired records. I think that'd be a good improvement to this test.
| IssuedFor: uid.New(), | ||
| ExpiresAt: time.Now().Add(-1), | ||
| } | ||
| _, err := CreateAccessKey(tx, ak) |
- remove expired records - encrypt device flow access key - add background jobs
ssoroka
force-pushed
the
device-flow-cleanup
branch
from
ba9928f to
b55d0ef
Compare
This reverts commit b55d0ef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist