Conversation
2bndy5
left a comment
There was a problem hiding this comment.
You forgot to update the package.lock file. Locally, you need to run npm install (at repo root).
Okay, I see, it changed after I ran |
|
Can you post the output for hte following commands? We're currently still on node v20.x. I ask because there seems to be some unexpected updates in the lock file. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 65 65
Lines 8654 8654
=======================================
Hits 7105 7105
Misses 1549 1549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok, thanks. They must be transitive dependencies or the latest versions that satisfy the constraints. |
Sure, but as a separate PR. It should probably go under a section titled "Building this project's docs". Although, I would try to keep the instructions agnostic to any platform. Personally, I hate using snap packages. I would prefer to replace
This reminds me that the tests snapshots need to be updated using a Linux OS (for various reasons), but that info would go in the tests/README.rst. |
See #479 |
I tried to add a (fancy) diagram created by https://mermaid.live/, but it didn't render. The reason is an old version of
mermaid. Updating to version 11.12.0, which is currently used at https://mermaid.live/, seems to fix the issue.Tested it on Ubuntu 24.04:
Fetch source code:
Install
uvpackage manager and Graphviz (fordot):Run build:
Build documentation:
HTML index file location:
If you want, I can add these instructions to https://github.com/jbms/sphinx-immaterial/blob/main/CONTRIBUTING.md for convenience.