Skip to content

feat(apidoc.cpp): conditionally add space between certain AST tokens#483

Merged
jbms merged 17 commits intojbms:mainfrom
laramiel:laramiel-patch-1
Feb 4, 2026
Merged

feat(apidoc.cpp): conditionally add space between certain AST tokens#483
jbms merged 17 commits intojbms:mainfrom
laramiel:laramiel-patch-1

Conversation

@laramiel
Copy link
Contributor

@laramiel laramiel commented Feb 1, 2026

…rators.

Removing extra spaces around namespace separators is a simple fix to improve type matching when the result of get_extent_spelling() is passed to _substitute_internal_type_names()

…rators.

Removing extra spaces around namespace separators is a simple fix to improve type matching when the result of get_extent_spelling() is passed to _substitute_internal_type_names()
@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.18%. Comparing base (b194f33) to head (0ca9125).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sphinx_immaterial/apidoc/cpp/api_parser.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   82.10%   82.18%   +0.08%     
==========================================
  Files          65       65              
  Lines        8654     8660       +6     
==========================================
+ Hits         7105     7117      +12     
+ Misses       1549     1543       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Improve space insertion between tokens in get_extent_spelling
Adjusted assertions in test case to reflect changes in expected output.
@laramiel
Copy link
Contributor Author

laramiel commented Feb 2, 2026

Done.

@2bndy5

This comment was marked as resolved.

Copy link
Collaborator

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To satisfy typing and style conventions, you can run the following command locally:

uvx nox -s ruff_format ruff_lint check_yaml check_json check_toml check_eof check_trailing_space check_lf

Assuming you have uv installed.

laramiel and others added 2 commits February 2, 2026 17:26
Co-authored-by: Brendan <2bndy5@gmail.com>
Co-authored-by: Brendan <2bndy5@gmail.com>
@2bndy5 2bndy5 changed the title In get_extent_spelling, remove extra whitespace around namespace sepa… feat(apidoc.cpp): conditionally add space between certain AST tokens Feb 3, 2026
2bndy5
2bndy5 previously requested changes Feb 3, 2026
Co-authored-by: Brendan <2bndy5@gmail.com>
Co-authored-by: Brendan <2bndy5@gmail.com>
@2bndy5 2bndy5 dismissed their stale review February 3, 2026 07:04

resolved

template match fix attempt
Removed unnecessary space handling for token pairs.
Removed unnecessary comment about source code consistency.
Reformatted no_spaces tuple for better readability.
@2bndy5 2bndy5 requested a review from jbms February 3, 2026 21:27
@jbms jbms merged commit 7fc957b into jbms:main Feb 4, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants