feat(apidoc.cpp): conditionally add space between certain AST tokens#483
Merged
feat(apidoc.cpp): conditionally add space between certain AST tokens#483
Conversation
…rators. Removing extra spaces around namespace separators is a simple fix to improve type matching when the result of get_extent_spelling() is passed to _substitute_internal_type_names()
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
==========================================
+ Coverage 82.10% 82.18% +0.08%
==========================================
Files 65 65
Lines 8654 8660 +6
==========================================
+ Hits 7105 7117 +12
+ Misses 1549 1543 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbms
reviewed
Feb 2, 2026
jbms
reviewed
Feb 2, 2026
Improve space insertion between tokens in get_extent_spelling
Incomplete test
Adjusted assertions in test case to reflect changes in expected output.
Contributor
Author
|
Done. |
This comment was marked as resolved.
This comment was marked as resolved.
2bndy5
requested changes
Feb 3, 2026
Collaborator
2bndy5
left a comment
There was a problem hiding this comment.
To satisfy typing and style conventions, you can run the following command locally:
uvx nox -s ruff_format ruff_lint check_yaml check_json check_toml check_eof check_trailing_space check_lfAssuming you have uv installed.
Co-authored-by: Brendan <2bndy5@gmail.com>
Co-authored-by: Brendan <2bndy5@gmail.com>
2bndy5
previously requested changes
Feb 3, 2026
Co-authored-by: Brendan <2bndy5@gmail.com>
2bndy5
reviewed
Feb 3, 2026
Co-authored-by: Brendan <2bndy5@gmail.com>
template match fix attempt
Removed unnecessary space handling for token pairs.
Removed unnecessary comment about source code consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rators.
Removing extra spaces around namespace separators is a simple fix to improve type matching when the result of get_extent_spelling() is passed to _substitute_internal_type_names()