Load system functions before running config#434
Merged
johnste merged 1 commit intojohnste:mainfrom Jun 4, 2025
belak-forks:belak/global-system-funcs
Merged
Load system functions before running config#434johnste merged 1 commit intojohnste:mainfrom belak-forks:belak/global-system-funcs
johnste merged 1 commit intojohnste:mainfrom
belak-forks:belak/global-system-funcs
Conversation
This fixes an issue where functions like finicky.getSystemInfo weren't available until after the config had already been loaded. In practical terms, these methods weren't available until a matcher was being called. This change fixes the bug by removing the setter methods and setting the functions immediately when the finicky object is created in the VM, rather than after all JS has been loaded. Fixes #429
johnste
approved these changes
Jun 4, 2025
Owner
|
Wonderful, thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where functions like finicky.getSystemInfo weren't available until after the config had already been loaded. In practical terms, these methods weren't available until a matcher was being called.
This change fixes the bug by removing the setter methods and setting the functions immediately when the finicky object is created in the VM, rather than after all JS has been loaded.
Fixes #429