Skip to content

"Move to trash" silently fails or removes file from library only when library is on a network share (NAS) #68

@OPGERUIMD97

Description

@OPGERUIMD97

Describe the bug
When attempting to trash a file from a library located on a NAS (network share), one of two things happens:

  • Error message — "Failed to move selected files to Trash. The files may not exist." — the file remains on disk and in the library --> in my case the file exist!!!
  • False success — a green confirmation message appears ("The file has been trashed") but the file is NOT moved to trash and remains on the NAS — it is only removed from the Lap library

In both cases the actual file on the NAS is not deleted and does not appear in any trash folder.

To Reproduce
Create a library pointing to a folder on a Network Share (NAS)

  • Select any file
  • Choose "Move to trash"
  • Either an error appears, or a success message appears — but the file remains on disk in both cases

Expected behavior Lap should detect that the file is on a network share where no system trash is available and either:

  • Warn the user that the file will be permanently deleted and ask for confirmation
  • Or move the file to a dedicated _LapTrash/ folder on the share for manual cleanup
  • At minimum: do not remove the file from the library if the actual disk deletion failed

Screenshots
See attached screenshots:

Screenshot 1 — error message after clicking "Trash all"
Image

Screenshot 2 — false green success message while file remains on NAS
Image

Environment
Lap v0.1.13, Windows and macOS
Photo's on network share

Additional context
network shares have no native trash/recycle bin. The silent failure (false success) is particularly dangerous — the user believes the file is gone while it still exists on disk, causing the library and the actual filesystem to go out of sync.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions