mark unavailable firmware as CURRENT#290
Merged
liske merged 1 commit intoliske:masterfrom Aug 9, 2024
Merged
Conversation
This changes the policy of reporting missing firmware updates as "UNKNOWN". Now, if there's no available firmware, we report "current". That fixes needrestart on platforms that do not have firmware support (liske#220) or platforms that *are* supported but for which a CPU is to new to have an updated firmware available (liske#149). It does *not* create a new "unavailable" status (liske#274) as this maps poorly in Nagios reporting, but that is an option that was considered here as well. Closes: liske#149 Closes: liske#274 Closes: liske#220
This was referenced Nov 21, 2023
Closed
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the policy of reporting missing firmware updates as "UNKNOWN". Now, if there's no available firmware, we report "current". That fixes needrestart on platforms that do not have firmware support (#220) or platforms that are supported but for which a CPU is to new to have an updated firmware available (#149).
It does not create a new "unavailable" status (#274) as this maps poorly in Nagios reporting, but that is an option that was considered here as well.
Closes: #149
Closes: #274
Closes: #220
This PR and #288 should fix all pending AMD firmware issues, and supersede #285 and possibly make #284 irrelevant as well.