Skip to content

[QSO Edit] Notes would not work if you edit a qso while being in the …#925

Merged
magicbug merged 1 commit intomagicbug:masterfrom
AndreasK79:qso_edit_notes_fix
Mar 7, 2021
Merged

[QSO Edit] Notes would not work if you edit a qso while being in the …#925
magicbug merged 1 commit intomagicbug:masterfrom
AndreasK79:qso_edit_notes_fix

Conversation

@AndreasK79
Copy link
Copy Markdown
Contributor

…qso entry area.

Thanks @leroydiazg for pointing this out.

@magicbug magicbug merged commit 68cb92f into magicbug:master Mar 7, 2021
@leroydiazg
Copy link
Copy Markdown
Contributor

Thanks @AndreasK79 for noticing the bug I posted in #878

As I explained there, this probably was my last contribution as I don't feel this project being quite contributing friendly . I'll keep an eye out on this project but I will focus now in other things.

@AndreasK79
Copy link
Copy Markdown
Contributor Author

@leroydiazg sorry to hear that. Thanks for the contributions to this project from you and @dgdavid. Btw there is a missing ) in frequency.php on line 38 in your 11m branch,

@dgdavid
Copy link
Copy Markdown

dgdavid commented Mar 10, 2021

@leroydiazg sorry to hear that. Thanks for the contributions to this project from you and @dgdavid.

Thanks a lot for your always kind words @AndreasK79 :) I agree with Leroy's feelings and I join him in both, leaving and wishing the project the best.

Btw there is a missing ) in frequency.php on line 38 in your 11m branch,

Yep, you're right. Thanks! I have to fix it properly (it was a quick and unfortunately dirty hotfix to avoid a crash when missing a default frequency after adding 11m)

See you around!

@AndreasK79 AndreasK79 deleted the qso_edit_notes_fix branch March 14, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants