Increase subpixel tolerance to fix ScrollArea.onBottomReached() while zoomed out.#8616
Merged
rtivital merged 1 commit intomantinedev:masterfrom Jan 15, 2026
Merged
Conversation
…le zoomed out. Fixes mantinedev#8608
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the ScrollArea.onBottomReached() callback fails to trigger when the browser is zoomed out. The fix increases the subpixel rendering tolerance from 0.6 to 0.8 pixels to account for larger subpixel discrepancies at extreme zoom levels (e.g., 33% zoom).
Changes:
- Increased the scroll threshold tolerance from -0.6 to -0.8 pixels
- Updated the inline comment to clarify the tolerance accounts for zoomed-out scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8608
I could only reproduce this issue when zoomed out to 33%, where I would see the difference between
(scrollTop - (scrollHeight - clientHeight) == 0.77. I found I could no longer reproduce the issue, even at extreme zooms with the tolerance set to 0.8. It does pass tests.