This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Retain underlying reader if it's an io.Seeker#327
Merged
mholt merged 9 commits intomholt:masterfrom Mar 21, 2022
jhwz:master
Merged
Retain underlying reader if it's an io.Seeker#327mholt merged 9 commits intomholt:masterfrom jhwz:master
mholt merged 9 commits intomholt:masterfrom
jhwz:master
Conversation
Conflicts: formats_test.go
mholt
suggested changes
Mar 21, 2022
Owner
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Ah, that's a good point. Thanks for testing this. How about this one bit of feedback?
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
mholt
approved these changes
Mar 21, 2022
Owner
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for another great contribution and for the test case, too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the new test case in
formats_test.go.Because we return an
io.MultiReader, we lose a lot of the methods on the interface. This means that when we identify a ZIP file, it cannot then be read with the returned reader.All this PR does is check if the underlying reader implements
io.Seeker, and if so return that instead.