Skip to content

fix: Log debug instead of errors when failing to parse NumPy annotations for additional sections#109

Merged
pawamoy merged 1 commit intomkdocstrings:masterfrom
sisp:fix/numpy-text-annotations
Oct 26, 2022
Merged

fix: Log debug instead of errors when failing to parse NumPy annotations for additional sections#109
pawamoy merged 1 commit intomkdocstrings:masterfrom
sisp:fix/numpy-text-annotations

Conversation

@sisp
Copy link
Copy Markdown
Contributor

@sisp sisp commented Oct 26, 2022

I've fixed support for NumPy annotations, that aren't conformant with PEP 484, for additional docstring sections:

  • Attributes
  • Returns
  • Receives
  • Yields

Follow-up of 75eeeda. Fixes #93 (comment).

@pawamoy pawamoy self-assigned this Oct 26, 2022
@pawamoy
Copy link
Copy Markdown
Member

pawamoy commented Oct 26, 2022

CI failures unrelated to your changes, I'll fix them.

@pawamoy
Copy link
Copy Markdown
Member

pawamoy commented Oct 26, 2022

Can you git rebase master please?

@sisp
Copy link
Copy Markdown
Contributor Author

sisp commented Oct 26, 2022

Done. 👍

Copy link
Copy Markdown
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect, thanks a lot @sisp!

@pawamoy pawamoy merged commit 568ff60 into mkdocstrings:master Oct 26, 2022
@sisp sisp deleted the fix/numpy-text-annotations branch October 28, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean operation in NumPy-style type annotation raises error

2 participants