CSHARP-5918: ExpressionNotSupportedException when a $set stage expression uses ToList method#1910
Open
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Open
CSHARP-5918: ExpressionNotSupportedException when a $set stage expression uses ToList method#1910sanych-sun wants to merge 1 commit intomongodb:mainfrom
sanych-sun wants to merge 1 commit intomongodb:mainfrom
Conversation
…sion uses ToList method
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes ExpressionNotSupportedException when a $set stage expression uses ToList() by replacing the manually constructed ListSerializer with the serializer obtained from the translation context (which respects the serializer map).
Changes:
- Fixed
ToListMethodToAggregationExpressionTranslatorto usecontext.GetSerializer(expression)instead of manually creating aListSerializer, ensuring the correct serializer is used - Added integration tests covering
ToList()in$setpipeline updates, both same-model and cross-model scenarios
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ToListMethodToAggregationExpressionTranslator.cs |
Use context-provided serializer instead of manually constructing one |
CSharp5918.cs |
New integration tests for the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was caused by the ToListMethodTranslater which used to ignore the serializerMap produced by the serializer finder and therefore used the wrong serializer.