fix(#1237): polyfill android Map.putIfAbsent#1252
Merged
gbrail merged 4 commits intomozilla:masterfrom Aug 6, 2022
naijun0403:master
Merged
fix(#1237): polyfill android Map.putIfAbsent#1252gbrail merged 4 commits intomozilla:masterfrom naijun0403:master
Map.putIfAbsent#1252gbrail merged 4 commits intomozilla:masterfrom
naijun0403:master
Conversation
tonygermano
reviewed
Aug 2, 2022
Contributor
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
I'd prefer to not add a new method to ScriptRuntime only to support a version of Android that has itself been unsupported by Google for 4 years.
I think it would be reasonable and have minimal impact to revert/rewrite the other sections to not use the unsupported method.
Instead, the code that originally used the method is changed to work even if it is not used
Collaborator
|
This looks reasonable to me. putIfAbsent is mainly a useful thing to have in concurrent hash maps. I'll test it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1237