Merged
Conversation
p-bakker
force-pushed
the
hashbang-support
branch
2 times, most recently
from
04fe3be to
88e2ebf
Compare
p-bakker
force-pushed
the
hashbang-support
branch
from
88e2ebf to
2a37c85
Compare
rbri
reviewed
Nov 5, 2023
Collaborator
|
@p-bakker another minor step forward - great overall it looks good, only a small comment, see above |
plain if
Collaborator
|
Makes sense to me too -- I'll try it out. Thanks! |
rbri
pushed a commit
to rbri/rhino
that referenced
this pull request
Nov 10, 2023
Support hashbang syntax at the start of a script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1274
Replaces #1341