Fix destructuring assignment errors

[tuchida]

Closes #1187

js> var a = []; var b = 0; [a[b+1]] = [123];
Exception in thread "main" java.lang.NullPointerException
	at org.mozilla.javascript.optimizer.BodyCodegen.generateExpression(BodyCodegen.java:967)
	at org.mozilla.javascript.optimizer.BodyCodegen.generateExpression(BodyCodegen.java:1233)
	at org.mozilla.javascript.optimizer.BodyCodegen.visitSetElem(BodyCodegen.java:4143)

This error has been corrected in this commit.

Closes #406

js> (1 ? {} : 490) = 1
Exception in thread "main" java.lang.ClassCastException: class org.mozilla.javascript.Node cannot be cast to class org.mozilla.javascript.ast.ObjectLiteral (org.mozilla.javascript.Node and org.mozilla.javascript.ast.ObjectLiteral are in unnamed module of loader 'app')
	at org.mozilla.javascript.Parser.destructuringAssignmentHelper(Parser.java:4046)
	at org.mozilla.javascript.Parser.createDestructuringAssignment(Parser.java:4016)
	at org.mozilla.javascript.IRFactory.createAssignment(IRFactory.java:2056)

This error has been corrected in this commit.

[p-bakker]

Nice!

[tuchida]

rhino/rhino/src/main/java/org/mozilla/javascript/IRFactory.java

Line 1112 in 5f55f04

Node d = parser.createDestructuringAssignment(node.getType(), left, right);

Because a variable declaration cannot be an expression, no transform is passed here.

var [a.b] = []; // SyntaxError

[tuchida]

var a;
for ([a] of [[1], [2], [3]]) {
  //
}

[tuchida]

var a;
[a] = [1];

[gbrail]

I'm trying to refresh my memory on test262.properties -- is this a long list of tests that we now have to disable becuase we broke them, or were these tests never run and we're actually able to pass 58% of them?

In other words, do these test262 changes represent an improvement, or a regression?

[p-bakker]

The test262Suite only looks at tests in directories that are already included in trst262.properties

So what you're seeing here in inclusion of a new directory full of tests, some of which already pass

Ran into this recently, tried to create a PR that will include ALL directories automatically, because this is a gap in our 'security net'. Didn't get around to finish it though....

[tuchida]

f772166 First I added language/expressions/assignment tests to test262.properties in the first commit.
1fd026f And two of those tests were improved.

[tuchida]

I added all directories to test262.properties. ref. #1531
I would like to merge that PR first.

[gbrail]

This looks good, but I merged your other 262.properties change and I'd feel better if you looked it over and resolved before merging. Thanks!

[tuchida]

f772166 Add assignment tests of test262

I deleted the commit. No other changes have been made.

[gbrail]

Thanks for working on this!