Skip to content

WebGLBackend: Configure scissor/viewport before clear.#30452

Merged
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev1
Feb 4, 2025
Merged

WebGLBackend: Configure scissor/viewport before clear.#30452
Mugen87 merged 1 commit intomrdoob:devfrom
Mugen87:dev1

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 4, 2025

Fixed #30450.

Description

The WebGL backend of WebGPURenderer must configure scissor and viewport before a clear operation. Otherwise it uses outdated values from the previous render.

@github-actions
Copy link

github-actions bot commented Feb 4, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.12
78.22
336.12
78.22
+0 B
+0 B
WebGPU 517.05
143.52
517.05
143.52
+0 B
-1 B
WebGPU Nodes 516.52
143.42
516.52
143.41
+0 B
-2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.17
112.09
465.17
112.09
+0 B
+0 B
WebGPU 589.05
159.72
589.05
159.72
+0 B
-1 B
WebGPU Nodes 544.42
149.28
544.42
149.28
+0 B
+0 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 4, 2025
@Mugen87 Mugen87 merged commit d9bc10b into mrdoob:dev Feb 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPURenderer: WebGL backend does not clear viewport correctly.

1 participant