WebGPURenderer: Fix mat2() arguments#30543
Merged
sunag merged 5 commits intomrdoob:devfrom Feb 17, 2025
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
Author
|
In WGSL specs, matrices without arguments are Zero Valued. Should we align to the specs or keep identity (GLSL behavior) like now? |
Collaborator
|
I think it's better to follow GLSL behavior as we are doing with other things in order to facilitate TSL Transpiler and code migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
mat2()incorrectly interpreted as vec4 in the Node Builder. This fix ensures correct type handling.This contribution is funded by Utsubo