Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Mar 7, 2025
| * Constructs a new lathe geometry. | ||
| * | ||
| * @param {Array<Vector2>} [points] - An array of points in 2D space. The x-coordinate of each point | ||
| * @param {Array<Vector2|Vector3>} [points] - An array of points in 2D space. The x-coordinate of each point |
Collaborator
There was a problem hiding this comment.
Why should we allow here Vector3?
Contributor
Author
There was a problem hiding this comment.
- CapsuleGeometry extends LatheGeometry
- CapsuleGeometry uses Path().getPoints( capSegments ) for points attribute
- Path extends CurvePath
- CurvePath.getPoints depends on CurvePath.getPoint
- CurvePath.getPoint returns a Vector2 or a Vector3
Mugen87
reviewed
Mar 7, 2025
Mugen87
reviewed
Mar 7, 2025
Mugen87
reviewed
Mar 7, 2025
Mugen87
approved these changes
Mar 7, 2025
Collaborator
|
@s-rigaud BTW: Thank you for all your contributions lately! Your PRs are an important QA for the project's JSDoc and also improve the overall code quality 🙌. |
Contributor
Author
|
Thanks a lot, I'm happy to help. It's nothing compare to your contributions over the years but just a few PRs might help the project QA 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix some types in the doc